Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix "Failed to extract zip" on Windows (by updating credential helpers) #1404

Merged
merged 5 commits into from
Feb 19, 2024

Conversation

pjcdawkins
Copy link
Collaborator

@pjcdawkins pjcdawkins commented Feb 7, 2024

The docker-credential-helpers are now distributed as binaries rather than zip or tgz archives.

@pjcdawkins pjcdawkins changed the title Disable credential helper to fix "Failed to extract zip" on Windows Fix "Failed to extract zip" on Windows Feb 7, 2024
@pjcdawkins pjcdawkins changed the title Fix "Failed to extract zip" on Windows Fix "Failed to extract zip" on Windows (by updating credential helpers) Feb 7, 2024
@pjcdawkins
Copy link
Collaborator Author

pjcdawkins commented Feb 7, 2024

The OS X version has signature problems

$ spctl -a ./credential-helper 
./credential-helper: invalid signature (code or signature have been modified)

docker/docker-credential-helpers#246

so I should restore the 0.6.4 version here

@pjcdawkins pjcdawkins merged commit 2287179 into main Feb 19, 2024
2 checks passed
@pjcdawkins pjcdawkins deleted the windows-no-zip-ext branch February 19, 2024 13:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant